remove CSS rules causing the header to get bigger #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
This seems to work! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves one of the issues present in #137 where the navbar gets bigger when users scroll down the page.
The resolution seemed to be to remove a couple CSS rules affecting the image top margin and the height of the images container. I do not know if this is likely to have broken anything else, but it seems unlikely to me.
CC @hannacodes Ben said you were the one mostly working on this. I'm just a random student contributor who isnt part of the team and I have no context for this issue to know whether this is the "proper" solution to the issue or not.
Testing