feat: add get_indexes
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenXiao1999
approved these changes
Nov 29, 2022
BowenXiao1999
approved these changes
Dec 5, 2022
Comment on lines
+39
to
+40
| assert indexes[0]["name"] == "three_columns_idx" | ||
| assert indexes[0]["column_names"] == ["id2", "id1"] |
There was a problem hiding this comment.
Can we get pk of this index?
There was a problem hiding this comment.
Now we can't. We have the ability to add and use indnkeyatts column in pg_index. The value of indnkeyatts means that how many keys in front of indkey are pk. We can support getting pk when we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait risingwavelabs/risingwave#6636 and risingwavelabs/risingwave#6717 to be merged.
close #10