Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): increase e2e test(dev mode) timeout to 15m #9987

Merged
merged 2 commits into from
May 24, 2023

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented May 24, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@yezizp2012 yezizp2012 requested a review from lmatz May 24, 2023 07:58
@yezizp2012 yezizp2012 requested review from shanicky and kwannoel May 24, 2023 07:59
@kwannoel
Copy link
Contributor

kwannoel commented May 24, 2023

Currently the timeout is due to roll back of @BugenZhao 's optimization
#7009, in the pull request: #9752.

TLDR: We can't finish backfill progress on first epoch, since state table can only be committed in second epoch. Which causes an increase in time taken to create materialized view on empty tables.

See this thread for full details: #9752 (comment).

To re-introduce the optimization there's a tracking issue: #9972.

Hence increasing the timeout is correct here for e2e tests, since there are many create materialized view statements on empty tables.

Overall performance should not be affected, see benchmark results: #9752 (comment)

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #9987 (48318b4) into main (e90d704) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9987      +/-   ##
==========================================
- Coverage   71.13%   71.12%   -0.01%     
==========================================
  Files        1252     1252              
  Lines      210190   210190              
==========================================
- Hits       149510   149491      -19     
- Misses      60680    60699      +19     
Flag Coverage Δ
rust 71.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yezizp2012 yezizp2012 added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 6e9bb26 May 24, 2023
@yezizp2012 yezizp2012 deleted the chore/incr-dev-e2e-timeout branch May 24, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants