-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pulsar oauth #8222
feat: pulsar oauth #8222
Conversation
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
it involves auth part, manually tested on stream native cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: tabVersion <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #8222 +/- ##
==========================================
- Coverage 71.65% 71.59% -0.07%
==========================================
Files 1131 1130 -1
Lines 184150 184013 -137
==========================================
- Hits 131948 131736 -212
- Misses 52202 52277 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
integration with stream native cloud
Checklist For Contributors
- [ ] I have added necessary unit tests and integration tests- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934)../risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
remove field:
admin.url
new fields:
oauth.issuer.url
,oauth.credentials.url
,oauth.audience
andoauth.scope
topic
topic
starts withnon-persistent://
, it can never seek to a specific position and will always read from latest with no exactly once guarantee.service.url
pulsar://
orpulsar+ssl://
scan.startup.mode
earliest
. accept one ofearliest
,latest
scan.startup.timestamp_millis
non-persistent
, it will read from the latest.auth.token
oauth.issuer.url
oauth.credentials.url
file://
oauth.audience
oauth.scope
Note that if user both set
oauth.*
auth andauth.token
, onlyoauth
authorisation is effective.if
oauth.*
providedoauth.issuer.url
oauth.credentials.url
oauth.audience
oauth.scope
we require admin privileges for the role.