-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: introduce ddl controller to make all ddl's running in the background #8145
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8145 +/- ##
==========================================
- Coverage 71.64% 71.57% -0.07%
==========================================
Files 1133 1134 +1
Lines 182249 182402 +153
==========================================
- Hits 130575 130561 -14
- Misses 51674 51841 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Can this PR be related with #8051? 🥸
Yes, that issue is partially supported in this PR but to fully support it still requires some persistence of state and metadata. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduced a ddl controller to run all ddl commands in the background to fix the deterministic recovery test fail in #8086 . The root cause is that when frontend got killed during running ddl, the requests will be cancelled by tonic, then only part of the operations will be applied in meta side.
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
Fix #8086
Fix #8131