feat(sink): add blackhole sink #6756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmatz
added
component/connector
user-facing-changes
Codecov Report
@@ Coverage Diff @@
## main #6756 +/- ##
==========================================
- Coverage 73.20% 73.20% -0.01%
==========================================
Files 1024 1024
Lines 163733 163741 +8
==========================================
- Hits 119860 119859 -1
- Misses 43873 43882 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tabVersion
approved these changes
Dec 7, 2022
|
Hey @lmatz, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
|
@lmatz I don't feel this sink should be documented. What do you think? Thanks. |
It's fine, not a must right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Blackhole sink does nothing, purely for performance test purposes.
So that branch https://github.com/risingwavelabs/risingwave/tree/disable_mv can be deleted.
Partially(?) unlock #5678, and performance test for stateless ETL cases.
Checklist
I have written necessary rustdoc comments./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Users can now create a sink with
blackholebeing the connector. It does nothing. It is helpful when we want to create a streaming query without a materialized view or a sink whose writes may affect the end-to-end performance.Refer to a related PR or issue link (optional)