-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): introduce new source executor #6447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 2356 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1139 | 1 | 1216 | 0 |
Click to see the invalid file list
- src/stream/src/executor/source/source_executor_v2.rs
Codecov Report
@@ Coverage Diff @@
## main #6447 +/- ##
==========================================
+ Coverage 73.94% 73.98% +0.04%
==========================================
Files 981 983 +2
Lines 159159 160693 +1534
==========================================
+ Hits 117690 118896 +1206
- Misses 41469 41797 +328
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is this PR related to the Unify the materialized source and table RFC? |
Yes. The tracking issue is here. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…elabs/risingwave into cyx/source-executor-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @xx01cyx, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
9a442ef
to
7258f7b
Compare
Hey @xx01cyx, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is the first step of the new DML design.
Summarize your change
Introduce new source executor. It differs from the current one in following ways:
SourceExecutorV2.stream_source_core
) becomes optional. That is to say, it is possible that a new source executor has no external connector. Under this circumstance, the new source executor's only responsibility is to receive and forward barrier messages.RowIdGenerateExecutor
(to be implemented).Describe any limitations of the current code
Datagen
is used to mock external connector in UT now. A better approach will be introducing a mock connector only for testing. (#6427)Checklist
./risedev check
(or alias,./risedev c
)Related Issue
#5949