Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): ban scaling of the mviews being created #5732

Merged
merged 10 commits into from
Oct 10, 2022

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As explained in #5728. This PR introduces (back, #122) the state of the table fragments. Currently, it has Creating as the initial value and Created after the mview is completely created (command "finish"es). For those fragments with Creating as the table fragments state, we'll throw an error if asked to scale.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Oct 9, 2022
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #5732 (c13921d) into main (b0fb507) will decrease coverage by 0.00%.
The diff coverage is 71.27%.

@@            Coverage Diff             @@
##             main    #5732      +/-   ##
==========================================
- Coverage   75.07%   75.06%   -0.01%     
==========================================
  Files         912      912              
  Lines      142660   142566      -94     
==========================================
- Hits       107098   107023      -75     
+ Misses      35562    35543      -19     
Flag Coverage Δ
rust 75.06% <71.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ctl/src/cmd_impl/meta/cluster_info.rs 0.00% <0.00%> (ø)
src/meta/src/barrier/mod.rs 85.45% <ø> (ø)
src/meta/src/rpc/server.rs 80.21% <ø> (-0.21%) ⬇️
src/meta/src/rpc/service/ddl_service.rs 3.52% <0.00%> (ø)
src/meta/src/stream/scale.rs 15.87% <0.00%> (-0.15%) ⬇️
src/meta/src/stream/source_manager.rs 30.10% <0.00%> (-0.14%) ⬇️
src/stream/src/from_proto/merge.rs 0.00% <0.00%> (ø)
src/stream/src/task/stream_manager.rs 2.75% <0.00%> (+<0.01%) ⬆️
src/meta/src/hummock/manager/mod.rs 79.09% <50.00%> (-0.16%) ⬇️
src/meta/src/model/stream.rs 61.72% <69.23%> (+0.62%) ⬆️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSSTM!

@mergify mergify bot merged commit c6a650d into main Oct 10, 2022
@mergify mergify bot deleted the bz/ban-scale-creating-mview branch October 10, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban scaling of "MV on MV" being created by introducing the table fragments state
3 participants