Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump madsim to support coarse clock #4901

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Thanks to @wangrunji0408's hard work, the madsim v0.2.4 supports simulating coarse clock, which is necessary for those systems without tsc support (mainly seen on virtual machines).

❯ cat /sys/devices/system/clocksource/clocksource0/available_clocksource
kvm-clock hpet acpi_pm 

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥵

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4901 (1f3183a) into main (aa6aebd) will increase coverage by 0.14%.
The diff coverage is 76.73%.

@@            Coverage Diff             @@
##             main    #4901      +/-   ##
==========================================
+ Coverage   73.80%   73.94%   +0.14%     
==========================================
  Files         871      874       +3     
  Lines      131635   133378    +1743     
==========================================
+ Hits        97148    98630    +1482     
- Misses      34487    34748     +261     
Flag Coverage Δ
rust 73.94% <76.73%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 72.30% <ø> (ø)
src/batch/src/executor/row_seq_scan.rs 16.92% <0.00%> (-0.45%) ⬇️
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/compute/src/lib.rs 2.85% <0.00%> (-0.27%) ⬇️
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/source/datagen/source/reader.rs 85.30% <ø> (-0.41%) ⬇️
src/ctl/src/cmd_impl/hummock/sst_dump.rs 0.00% <0.00%> (ø)
... and 148 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 3ea970a into main Aug 25, 2022
@mergify mergify bot deleted the bz/bump-madsim-clockid-6 branch August 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Seems like deterministic test will occasionally panic when broken fifo_channel error happens
2 participants