-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: value encoding error #4671
Conversation
LGTM |
Codecov Report
@@ Coverage Diff @@
## main #4671 +/- ##
==========================================
- Coverage 74.08% 74.04% -0.05%
==========================================
Files 862 859 -3
Lines 129157 129198 +41
==========================================
- Hits 95685 95663 -22
- Misses 33472 33535 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
value_encoding
crate to return its own Errorvalue-encoding
crate (src/utils/value-encoding
) cc. @BowenXiao1999ScalarImpl::bytes_to_scalar
tofrom_proto_bytes
to avoid misusingfrom_proto_bytes
to value encoding (at least for struct/list) #4672Checklist
./risedev check
(or alias,./risedev c
)Documentation
N/A
Refer to a related PR or issue link (optional)
related #4077