Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: value encoding error #4671

Merged
merged 6 commits into from
Aug 16, 2022
Merged

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Aug 16, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

N/A

Refer to a related PR or issue link (optional)

related #4077

@yuhao-su
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #4671 (3eb5448) into main (e88dd9a) will decrease coverage by 0.04%.
The diff coverage is 43.12%.

❗ Current head 3eb5448 differs from pull request most recent head f36523e. Consider uploading reports for the commit f36523e to get more accurate results

@@            Coverage Diff             @@
##             main    #4671      +/-   ##
==========================================
- Coverage   74.08%   74.04%   -0.05%     
==========================================
  Files         862      859       -3     
  Lines      129157   129198      +41     
==========================================
- Hits        95685    95663      -22     
- Misses      33472    33535      +63     
Flag Coverage Δ
rust 74.04% <43.12%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 17.36% <0.00%> (ø)
src/common/src/types/chrono_wrapper.rs 87.57% <0.00%> (ø)
src/common/src/util/value_encoding/error.rs 0.00% <ø> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/expr/src/expr/expr_binary_nonnull.rs 84.00% <ø> (ø)
src/expr/src/expr/expr_regexp.rs 0.00% <0.00%> (ø)
src/expr/src/table_function/regexp_matches.rs 0.00% <0.00%> (ø)
src/meta/src/hummock/manager/compaction.rs 14.28% <0.00%> (-85.72%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 39.20% <0.00%> (-0.97%) ⬇️
src/meta/src/rpc/service/hummock_service.rs 6.38% <0.00%> (-0.09%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 32a3546 into main Aug 16, 2022
@mergify mergify bot deleted the eric/refactor_value_encoding_error branch August 16, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants