Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support user alter #4261

Merged
merged 9 commits into from
Jul 29, 2022
Merged

feat(frontend): support user alter #4261

merged 9 commits into from
Jul 29, 2022

Conversation

cnissnzg
Copy link
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

support alter user syntax in #2643

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Resolve #3998

@cnissnzg cnissnzg changed the title alter user feat(frontend) support user alter Jul 28, 2022
@cnissnzg cnissnzg changed the title feat(frontend) support user alter feat(frontend): support user alter Jul 28, 2022
@cnissnzg cnissnzg requested a review from yezizp2012 July 28, 2022 09:18
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #4261 (cf38974) into main (1da2a3e) will decrease coverage by 0.02%.
The diff coverage is 60.88%.

@@            Coverage Diff             @@
##             main    #4261      +/-   ##
==========================================
- Coverage   74.36%   74.34%   -0.03%     
==========================================
  Files         843      844       +1     
  Lines      121654   121895     +241     
==========================================
+ Hits        90471    90625     +154     
- Misses      31183    31270      +87     
Flag Coverage Δ
rust 74.34% <60.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/user/user_service.rs 10.14% <0.00%> (-0.63%) ⬇️
src/meta/src/manager/user.rs 83.61% <0.00%> (-5.28%) ⬇️
src/meta/src/rpc/service/user_service.rs 7.85% <0.00%> (-1.16%) ⬇️
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_response.rs 71.21% <ø> (ø)
src/frontend/src/handler/create_user.rs 88.88% <66.66%> (ø)
src/frontend/src/user/user_manager.rs 64.40% <66.66%> (+16.25%) ⬆️
src/frontend/src/handler/alter_user.rs 78.70% <78.70%> (ø)
src/sqlparser/src/ast/statement.rs 83.71% <82.97%> (+1.08%) ⬆️
src/sqlparser/src/parser.rs 92.21% <87.50%> (-0.03%) ⬇️
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some e2e test as well.

proto/user.proto Show resolved Hide resolved
src/sqlparser/src/ast/statement.rs Outdated Show resolved Hide resolved
src/sqlparser/src/parser.rs Outdated Show resolved Hide resolved
src/meta/src/manager/user.rs Outdated Show resolved Hide resolved
src/meta/src/manager/user.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/alter_user.rs Show resolved Hide resolved
src/sqlparser/src/ast/statement.rs Outdated Show resolved Hide resolved
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test for parser, location: src/sqlparser/tests/testdata.

src/meta/src/manager/user.rs Outdated Show resolved Hide resolved
src/meta/src/manager/user.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/alter_user.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/alter_user.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/alter_user.rs Outdated Show resolved Hide resolved
src/meta/src/rpc/service/user_service.rs Show resolved Hide resolved
@cnissnzg cnissnzg added the user-facing-changes Contains changes that are visible to users label Jul 29, 2022
@mergify mergify bot merged commit a15b40a into main Jul 29, 2022
@mergify mergify bot deleted the yifeng/UserAlter-3998 branch July 29, 2022 10:17
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* alter user

* fix

* fix

* fix typo in e2e test

* fmt

* fix

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax to support user alter.
2 participants