Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): add DivisionByZero error #4236

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 27, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

😄💦

close #3939

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #4236 (494bb4a) into main (16412f2) will decrease coverage by 0.00%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##             main    #4236      +/-   ##
==========================================
- Coverage   73.98%   73.97%   -0.01%     
==========================================
  Files         843      843              
  Lines      120590   120601      +11     
==========================================
+ Hits        89214    89216       +2     
- Misses      31376    31385       +9     
Flag Coverage Δ
rust 73.97% <38.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/decimal.rs 79.67% <0.00%> (-1.33%) ⬇️
src/expr/src/error.rs 40.00% <ø> (ø)
src/expr/src/vector_op/arithmetic_op.rs 52.31% <83.33%> (+0.42%) ⬆️
src/common/src/types/ordered_float.rs 28.91% <0.00%> (-0.20%) ⬇️
src/meta/src/manager/id.rs 94.47% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kwannoel
Copy link
Contributor

Closes #3939 ? 👀

@xxchan
Copy link
Member Author

xxchan commented Jul 27, 2022

Closes #3939 ? 👀

Partly solved. But IIRC we will return broken fifo? 😄

dev=> select 1/0;
ERROR:  QueryError: Invalid Parameter Value: Out of range.
dev=> select 1/v from t;
ERROR:  QueryError: RPC error: Status { code: Internal, message: "internal error: broken fifo_channel", metadata: MetadataMap { headers: {"risingwave-error-bin": "CAESI2ludGVybmFsIGVycm9yOiBicm9rZW4gZmlmb19jaGFubmVs"} }, source: None }.
dev=>

But yes we can close it, and track broken fifo in other issue. Maybe #3730 or #3908

@kwannoel
Copy link
Contributor

kwannoel commented Jul 27, 2022

Closes #3939 ? eyes

Partly solved. But IIRC we will return broken fifo? smile

dev=> select 1/0;
ERROR:  QueryError: Invalid Parameter Value: Out of range.
dev=> select 1/v from t;
ERROR:  QueryError: RPC error: Status { code: Internal, message: "internal error: broken fifo_channel", metadata: MetadataMap { headers: {"risingwave-error-bin": "CAESI2ludGVybmFsIGVycm9yOiBicm9rZW4gZmlmb19jaGFubmVs"} }, source: None }.
dev=>

Tracked separately here: #3908

EDIT: Saw the update from message above 👍

@mergify mergify bot merged commit 37f30b8 into main Jul 27, 2022
@mergify mergify bot deleted the xxchan/unacceptable-hookworm branch July 27, 2022 15:41
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlsmith bug hunt: division by zero should return division_by_zero error code
3 participants