-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): add DivisionByZero error #4236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4236 +/- ##
==========================================
- Coverage 73.98% 73.97% -0.01%
==========================================
Files 843 843
Lines 120590 120601 +11
==========================================
+ Hits 89214 89216 +2
- Misses 31376 31385 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Closes #3939 ? 👀 |
Partly solved. But IIRC we will return dev=> select 1/0;
ERROR: QueryError: Invalid Parameter Value: Out of range.
dev=> select 1/v from t;
ERROR: QueryError: RPC error: Status { code: Internal, message: "internal error: broken fifo_channel", metadata: MetadataMap { headers: {"risingwave-error-bin": "CAESI2ludGVybmFsIGVycm9yOiBicm9rZW4gZmlmb19jaGFubmVs"} }, source: None }.
dev=> But yes we can close it, and track |
EDIT: Saw the update from message above 👍 |
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
😄💦
close #3939
Checklist
./risedev check
(or alias,./risedev c
)