Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): support repeat function #3148

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

name1e5s
Copy link
Contributor

What's changed and what's your intention?

Add support for repeat function

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#112

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #3148 (a68f8f9) into main (3acee84) will decrease coverage by 0.00%.
The diff coverage is 62.79%.

@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
- Coverage   73.51%   73.51%   -0.01%     
==========================================
  Files         737      738       +1     
  Lines      101632   101671      +39     
==========================================
+ Hits        74719    74743      +24     
- Misses      26913    26928      +15     
Flag Coverage Δ
rust 73.51% <62.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/build_expr_from_prost.rs 74.53% <0.00%> (-1.43%) ⬇️
src/expr/src/expr/expr_binary_bytes.rs 79.61% <0.00%> (-6.71%) ⬇️
src/expr/src/expr/mod.rs 51.02% <0.00%> (-1.07%) ⬇️
src/expr/src/vector_op/repeat.rs 100.00% <100.00%> (ø)
src/frontend/src/binder/expr/function.rs 81.09% <100.00%> (+0.11%) ⬆️
src/frontend/src/expr/type_inference.rs 98.99% <100.00%> (-0.01%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Contributor

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang TennyZhuang merged commit d571760 into risingwavelabs:main Jun 12, 2022
@xiangjinwu xiangjinwu added the user-facing-changes Contains changes that are visible to users label Jun 13, 2022
@stdrc stdrc mentioned this pull request Jun 28, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants