refactor(array): introduce ArrayError & unify ensure! by anyhow!
#3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
requested review from
liurenjie1024,
skyzh,
neverchanje,
TennyZhuang and
fuyufjh
Codecov Report
@@ Coverage Diff @@
## main #3130 +/- ##
==========================================
+ Coverage 73.75% 73.76% +0.01%
==========================================
Files 736 737 +1
Lines 101680 101611 -69
==========================================
- Hits 74992 74955 -37
+ Misses 26688 26656 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
skyzh
approved these changes
Jun 10, 2022
BugenZhao
changed the title
ensure! by anyhow!
TennyZhuang
approved these changes
Jun 10, 2022
skyzh
reviewed
Jun 10, 2022
| fn read(buf: &[u8]) -> ArrayResult<Decimal> { | ||
| match Decimal::from_str(Utf8ValueReader::read(buf)?) { | ||
| Ok(d) => Ok(d), | ||
| Err(e) => bail!("failed to read decimal from string: {}", e), |
There was a problem hiding this comment.
It would be better to use anyhow's context function to attach extra info to an existing error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This PR introduces
ArrayError, and unifies theensuremacro by usinganyhow!everywhere so that it can work under any context includingRwError,ArrayError, andExprError.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)