Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support grant/revoke privilege in frontend #3004

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jun 6, 2022

What's changed and what's your intention?

As title, support Grant/Revoke privilege in frontend described in #2643 .

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Resolve #2945

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #3004 (df07015) into main (d734c4b) will increase coverage by 0.06%.
The diff coverage is 74.60%.

@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   73.15%   73.22%   +0.06%     
==========================================
  Files         724      725       +1     
  Lines       97243    97523     +280     
==========================================
+ Hits        71135    71407     +272     
- Misses      26108    26116       +8     
Flag Coverage Δ
rust 73.22% <74.60%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/user/user_manager.rs 52.63% <0.00%> (+7.89%) ⬆️
src/frontend/src/user/user_service.rs 12.96% <0.00%> (ø)
src/meta/src/manager/catalog.rs 19.14% <0.00%> (+0.26%) ⬆️
src/meta/src/rpc/service/user_service.rs 0.00% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_response.rs 68.42% <ø> (ø)
src/frontend/src/handler/handle_privilege.rs 65.97% <65.97%> (ø)
src/sqlparser/src/ast/mod.rs 89.48% <80.76%> (-0.05%) ⬇️
src/sqlparser/src/parser.rs 92.29% <87.09%> (-0.09%) ⬇️
src/meta/src/manager/user.rs 87.94% <92.36%> (+0.18%) ⬆️
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 marked this pull request as ready for review June 6, 2022 09:46
@yezizp2012 yezizp2012 added the user-facing-changes Contains changes that are visible to users label Jun 6, 2022
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/meta/src/manager/catalog.rs Show resolved Hide resolved
@yezizp2012 yezizp2012 enabled auto-merge (squash) June 7, 2022 05:19
@yezizp2012 yezizp2012 merged commit 1c467da into main Jun 7, 2022
@yezizp2012 yezizp2012 deleted the feat/user-privilege-fte branch June 7, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend: syntax to support user create/drop.
3 participants