Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): introduce user service in meta, to support user and privilege management #2745

Merged
merged 11 commits into from
May 30, 2022

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented May 23, 2022

What's changed and what's your intention?

As title.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visibile to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Part of #2193 #2643

@yezizp2012 yezizp2012 marked this pull request as draft May 23, 2022 11:20
@yezizp2012 yezizp2012 changed the title feat: introduce user service in meta, to support user and privilege management feat(meta): introduce user service in meta, to support user and privilege management May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2745 (c7e732d) into main (e33de50) will decrease coverage by 0.05%.
The diff coverage is 61.95%.

@@            Coverage Diff             @@
##             main    #2745      +/-   ##
==========================================
- Coverage   72.69%   72.64%   -0.06%     
==========================================
  Files         702      705       +3     
  Lines       91948    92466     +518     
==========================================
+ Hits        66845    67168     +323     
- Misses      25103    25298     +195     
Flag Coverage Δ
rust 72.64% <61.95%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/catalog/mod.rs 56.25% <ø> (ø)
src/meta/src/manager/catalog.rs 19.08% <0.00%> (-0.92%) ⬇️
src/meta/src/model/mod.rs 99.05% <ø> (ø)
src/meta/src/rpc/server.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/mod.rs 0.00% <ø> (ø)
src/meta/src/rpc/service/user_service.rs 0.00% <0.00%> (ø)
src/meta/src/model/user.rs 75.00% <75.00%> (ø)
src/meta/src/manager/user.rs 87.25% <87.25%> (ø)
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 marked this pull request as ready for review May 26, 2022 07:08
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Generally LGTM

@yezizp2012 yezizp2012 merged commit 3a4eb80 into main May 30, 2022
@yezizp2012 yezizp2012 deleted the feat/user-privilege-service branch May 30, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants