-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add user and privilege proto definition #2645
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2645 +/- ##
=======================================
Coverage 72.19% 72.19%
=======================================
Files 681 681
Lines 88477 88494 +17
=======================================
+ Hits 63872 63888 +16
- Misses 24605 24606 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Do we have a plan for what SQL we want to support specifically? There are several options in Postgres's CREATE USER command, https://www.postgresql.org/docs/current/sql-createuser.html. I think we need a priority and focus on delivering a minimized feature set. I don't know what is required in the initial stage. |
Please visit #2643 for more details. I list all syntaxes we plan to support in current stage. |
What's changed and what's your intention?
As title, according to #2643
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
Part of #2193