feat: support cast between integer and bool #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xiaoyong-z
force-pushed
the
integer-bool-cast
branch
from
849a8d3 to
1c10265
Compare
Signed-off-by: xyz <[email protected]>
xiaoyong-z
force-pushed
the
integer-bool-cast
branch
from
1c10265 to
7cdbe43
Compare
xiangjinwu
reviewed
May 9, 2022
src/expr/src/vector_op/cast.rs
Outdated
Comment on lines
220
to
223
| match input { | ||
| 0 => Ok(false), | ||
| _ => Ok(true), | ||
| } |
src/expr/src/expr/expr_unary.rs
Outdated
Comment on lines
105
to
110
| { boolean, int16, general_cast }, | ||
| { boolean, int32, general_cast }, | ||
| { boolean, int64, general_cast }, | ||
| { int16, boolean, int16_to_bool }, | ||
| { int32, boolean, int32_to_bool }, | ||
| { int64, boolean, int64_to_bool }, |
There was a problem hiding this comment.
PostgreSQL only allows casting between boolean and int32. We do not need to use macro/generic to support int16 and int64.
Signed-off-by: xyz <[email protected]>
xiaoyong-z
force-pushed
the
integer-bool-cast
branch
from
680689f to
3e9a075
Compare
xiangjinwu
approved these changes
May 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #2370 +/- ##
=======================================
Coverage 71.26% 71.26%
=======================================
Files 688 688
Lines 86985 86995 +10
=======================================
+ Hits 61987 61998 +11
+ Misses 24998 24997 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xyz [email protected]
What's changed and what's your intention?
This pr add support for casting between integer and bool.
Cast from integer to bool: 0 -> false , other -> true.
Cast from bool to integer: false -> 0, true -> 1.
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
- [ ] I have written necessary docs and commentsRefer to a related PR or issue link (optional)
#112