perf(storage): use VecDeque for TableChangeLog to avoid large clone on truncate (#19984) #20003
+78
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+150
to
+154
| while let Some(change_log) = self.0.front() | ||
| && *change_log.epochs.last().expect("non-empty") <= truncate_epoch | ||
| { | ||
| let _change_log = self.0.pop_front().expect("non-empty"); | ||
| } |
There was a problem hiding this comment.
The while let pattern with && condition can cause a panic since the right side of && will be evaluated even when front() returns None. Here's a safer way to write this:
while let Some(change_log) = self.0.front() {
if change_log.epochs.last().expect("non-empty") <= &truncate_epoch {
let _change_log = self.0.pop_front().expect("non-empty");
} else {
break;
}
}Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
The while let pattern with && condition can cause a panic since the right side of && will be evaluated even when front() returns None
@wenym1 This seems not true? I tried rust playground and short-circuiting is working withwhile let
Graphite Automations"release branch request review" took an action on this PR • (01/02/25)1 reviewer was added to this PR based on xxchan's automation. |
Li0k
approved these changes
Jan 2, 2025
zwang28
approved these changes
Jan 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…n truncate (#19984) (#20003) Co-authored-by: William Wen <[email protected]>
cyliu0
deleted the
auto-release-2.2-5cb0d17182de20354df198477b9955d5689e82ba-1735813276
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking #19984 onto branch release-2.2,
This PR/issue was created by cherry-pick action from commit 5cb0d17.,