Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dashboard): refactor back-pressure calculation #20001

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jan 2, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Based on the previous PR, this PR rewrite the back-pressure calculation code in much less code.

I did this because I am going to add more statistics to the Web dashboard, such as streaming throughput.

Due to my mistake, #19954 was incorrectly merged into graphite-base/19954

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@fuyufjh fuyufjh enabled auto-merge January 2, 2025 15:08
@fuyufjh fuyufjh added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit c28ea2d Jan 2, 2025
33 of 35 checks passed
@fuyufjh fuyufjh deleted the eric/refactor_bp_data branch January 2, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants