Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: batching telemetry event request avoid too many requests #20000

Merged
merged 10 commits into from
Jan 8, 2025
+63 −16
Merged

feat: batching telemetry event request avoid too many requests #20000

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
14ab498
batch message
Jan 2, 2025
9731e9c
restore telemetry etcd backend
Jan 2, 2025
5c6578f
batching
Jan 2, 2025
015af02
batch size trigger report
Jan 3, 2025
15de8b9
Merge branch 'main' into tab/batching-telemetry-request
tabVersion Jan 3, 2025
3ed7e87
fix
Jan 3, 2025
9ffe508
fmt
Jan 3, 2025
a50d227
fix
tabVersion Jan 3, 2025
e793e2c
Merge branch 'main' into tab/batching-telemetry-request
tabVersion Jan 3, 2025
b0274f9
fix dylint
Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions proto/telemetry.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@

option go_package = "risingwavelabs.com/risingwave/proto/telemetry";

enum MetaBackend {

Check failure on line 7 in proto/telemetry.proto

View workflow job for this annotation

GitHub Actions / Check breaking changes in Protobuf files 

Previously present reserved name "META_BACKEND_ETCD" on enum "MetaBackend" was deleted.

Check failure on line 7 in proto/telemetry.proto

View workflow job for this annotation

GitHub Actions / Check breaking changes in Protobuf files 

Previously present reserved range "[2]" on enum "MetaBackend" is missing values: [2] were removed.
META_BACKEND_UNSPECIFIED = 0;
META_BACKEND_MEMORY = 1;
reserved 2;
reserved "META_BACKEND_ETCD";
Comment on lines -10 to -11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telemetry service still receive requests from legacy clusters and it is still possible getting reports from a ETCD backend cluster.
I believe the field is changed by mistake in #18621
There is no breaking change in the proto file because there is no updates on the server side since then.

META_BACKEND_ETCD = 2;
META_BACKEND_RDB = 3;
}

Expand Down Expand Up @@ -167,3 +166,7 @@
// mark the event is a test message
bool is_test = 11;
}

message BatchEventMessage {
repeated EventMessage events = 1;
}
Loading