Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove e2e test RUN_COMPACTION #19970

Merged
merged 4 commits into from
Dec 31, 2024
Merged

ci: remove e2e test RUN_COMPACTION #19970

merged 4 commits into from
Dec 31, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 31, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@graphite-app graphite-app bot requested a review from a team December 31, 2024 07:02
@xxchan xxchan changed the title ci: fix e2e test RUN_COMPACTION ci: remove e2e test RUN_COMPACTION Dec 31, 2024
@xxchan
Copy link
Member Author

xxchan commented Dec 31, 2024

Discussed with @zwang28, the compaction test isn't very useful and we can remove it.

Here we removed it from the script, and pr.env isn't useful anymore and we can unify run-e2e-test.sh and e2e-test-serial.sh. @zwang28 will delete the code in kernel later.

@xxchan xxchan added this pull request to the merge queue Dec 31, 2024
Merged via the queue into main with commit 76a6d1d Dec 31, 2024
28 of 30 checks passed
@xxchan xxchan deleted the xxchan/salty-koala branch December 31, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants