Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source): prefer options_with_secret over with_properties in SpecificParserConfig::new #19900

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The PR #17456 (commit 96de664) updated one occurrence below but missed the other two fixed in this PR.

.clone_from(get_kafka_topic(&options_with_secret)?);

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

let options_with_secret =
LocalSecretManager::global().fill_secrets(options.clone(), secret_refs.clone())?;
LocalSecretManager::global().fill_secrets(options, secret_refs)?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary clone

@tabVersion tabVersion added this pull request to the merge queue Dec 31, 2024
Merged via the queue into main with commit 1d4ab61 Dec 31, 2024
29 of 30 checks passed
@tabVersion tabVersion deleted the refactor-source-parser-config-secret branch December 31, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants