Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source): remove chunk splitting logic in apply_rate_limit #19826

Open
wants to merge 1 commit into
base: rc/respect-chunk-size-limit
Choose a base branch
from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Dec 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After #19698, we can expect chunks yielded to SourceExecutors to be smaller than SourceCtrlOpts::chunk_size, so we don't need to split chunks in apply_rate_limit (used by FetchExecutor, FsSourceExecutor, SourceBackfillExecutor and SourceExecutor) anymore.

This PR removes the chunk splitting logic from apply_rate_limit.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

stdrc commented Dec 17, 2024

@stdrc stdrc changed the title remove chunk splitting logic in apply_rate_limit refactor(source): remove chunk splitting logic in apply_rate_limit Dec 17, 2024
@stdrc stdrc marked this pull request as ready for review December 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant