Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix missing rewrite of table fragments during migration to sql backend #19813

Open
wants to merge 4 commits into
base: release-2.0
Choose a base branch
from
Open

fix: fix missing rewrite of table fragments during migration to sql backend #19813

wants to merge 4 commits into from
+94 −18

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Dec 16, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #19808 .
Fix #19825 .

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@yezizp2012 yezizp2012 requested a review from yuhao-su December 16, 2024 13:02
@github-actions github-actions bot added the type/fix Bug fix label Dec 16, 2024
@yezizp2012 yezizp2012 requested a review from shanicky December 16, 2024 13:03
@yezizp2012
Copy link
Member Author

I'm not sure whether this PR updates every fields where secrets are referenced in the streaming metadata. @yuhao-su Please help to confirm that.

@yuhao-su
Copy link
Contributor

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao-su yuhao-su yuhao-su approved these changes

@shanicky shanicky Awaiting requested review from shanicky

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ci/run-e2e-sql-migration-tests type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yezizp2012 @yuhao-su