Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): fix compatibility upgrading from v2.1.0 for singleton vnode count #19760

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Dec 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In #18753, we mentioned that...

For SQL backend, correctly perform the migration to fill 1 for the vnode_count field of singletons.

However, consider the singleton internal table of the Source executor, of which maybe_vnode_count in its protobuf representation is set to the value of hash-distributed Source fragment if users upgrade from v2.1. Our migration script on SQL models can't cover such case, which break the assertions introduced later in #19267.

This should address the backward-compat test failure in main-cron CI these days.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao added ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. ci/main-cron/run-selected labels Dec 11, 2024
@github-actions github-actions bot added the type/fix Bug fix label Dec 11, 2024
@graphite-app graphite-app bot requested a review from a team December 11, 2024 09:16
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested a review from yezizp2012 December 11, 2024 09:43
@BugenZhao BugenZhao added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 58adff7 Dec 12, 2024
32 of 33 checks passed
@BugenZhao BugenZhao deleted the bz/fix-singleton-vnode-count-compat-assertion branch December 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/main-cron/run-selected ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants