Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot-backfill): fix incorrect recv barrier and add test for recover #19756

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Dec 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously after snapshot backfill finishes and when the executor is recreated in recovery, we incorrectly do a recv_next_barrier, which will cause the recover to be stuck forever.

In this PR, we fix this bug and add test for the case of recovery.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

wenym1 commented Dec 11, 2024

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@graphite-app graphite-app bot requested a review from a team December 11, 2024 09:56
@wenym1 wenym1 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 013725d Dec 12, 2024
47 of 48 checks passed
@wenym1 wenym1 deleted the yiming/fix-snapshot-backfill-extra-recv branch December 12, 2024 07:03
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants