Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add fix create definition cmd in rise ctl #19744

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Dec 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#18393 fixed an issue where certain source/table definition was invalid SQL (see tests in commit c0f95c8 for examples).

This PR provides a tool to fix the definition in-place for sources/table created before v2.0.1, when drop and recreate is not feasible.

./risedev ctl debug fix-create-definition --etcd-endpoints localhost:2388 --dry-run
./risedev ctl debug fix-create-definition --etcd-endpoints localhost:2388

# add following options if auth enabled for etcd
--enable-etcd-auth --etcd-username xxxx --etcd-password yyyy

Example:

source: id=1, name=src:
	old definition: CREATE SOURCE IF NOT EXISTS src (*WATERMARK FOR event_time AS event_time - INTERVAL '60' SECOND) WITH (kafka.topic = 'abc', kafka.brokers = 'localhost:1001') FORMAT PLAIN ENCODE PROTOBUF (message = 'Foo', schema.registry = 'http://')
	new definition: CREATE SOURCE IF NOT EXISTS src (*, WATERMARK FOR event_time AS event_time - INTERVAL '60' SECOND) WITH (kafka.topic = 'abc', kafka.brokers = 'localhost:1001') FORMAT PLAIN ENCODE PROTOBUF (message = 'Foo', schema.registry = 'http://')
table definition updated

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yezizp2012 yezizp2012 merged commit 02958eb into wangzheng/release-2.0-patch Dec 10, 2024
22 of 29 checks passed
@yezizp2012 yezizp2012 deleted the fix/patch-fix-create-comma branch December 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants