Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): make commit checkpoint interval default 60 for iceberg engine table #19738

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Dec 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example:

create table t(id int primary key, name varchar) with(commit_checkpoint_interval = 1) engine = iceberg;

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Support configure commit_checkpoint_interval for iceberg engine table.

Example:

create table t(id int primary key, name varchar) with(commit_checkpoint_interval = 1) engine = iceberg;

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Dec 10, 2024
Copy link
Contributor

Hi, there.

📝 Telemetry Reminder:
If you're implementing this feature, please consider adding telemetry metrics to track its usage. This helps us understand how the feature is being used and improve it further.
You can find the function report_event of telemetry reporting in the following files. Feel free to ask questions if you need any guidance!

  • src/frontend/src/telemetry.rs
  • src/meta/src/telemetry.rs
  • src/stream/src/telemetry.rs
  • src/storage/compactor/src/telemetry.rs
    Or calling report_event_common (src/common/telemetry_event/src/lib.rs) as if finding it hard to implement.
    ✨ Thank you for your contribution to RisingWave! ✨

This is an automated comment created by the peaceiris/actions-label-commenter. Responding to the bot or mentioning it won't have any effect.

@graphite-app graphite-app bot requested a review from a team December 11, 2024 02:32
@chenzl25 chenzl25 enabled auto-merge December 11, 2024 07:19
@chenzl25 chenzl25 disabled auto-merge December 11, 2024 07:20
@chenzl25 chenzl25 enabled auto-merge December 11, 2024 07:42
@chenzl25 chenzl25 added this pull request to the merge queue Dec 11, 2024
@graphite-app graphite-app bot requested a review from a team December 11, 2024 09:31
Merged via the queue into main with commit 9292b6f Dec 11, 2024
28 of 29 checks passed
@chenzl25 chenzl25 deleted the dyaln/make_iceberg_engine_commit_checkpoint_interval_configurable branch December 11, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants