-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(meta): filter out SSTs for time travel metadata #19694
base: main
Are you sure you want to change the base?
Conversation
rewriting is LGTM. My question is: The PR retains three types
This is not consistent with the previous implementation (which only kept MaterializedView), is this as expected? Can you add some pr description. |
Only user-queryable state tables are included in the time travel metadata, both for previous implementation and current one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #19598
Only user-queryable state tables are included in the time travel metadata, i.e.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.