Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): filter out SSTs for time travel metadata #19694

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Dec 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #19598

Only user-queryable state tables are included in the time travel metadata, i.e.

  • TableType::Table
  • TableType::MaterializedView
  • TableType::Index

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 enabled auto-merge December 6, 2024 03:55
@graphite-app graphite-app bot requested a review from a team December 6, 2024 03:58
@zwang28 zwang28 disabled auto-merge December 6, 2024 05:47
@zwang28 zwang28 changed the title refactor(meta): clean up legacy code refactor(meta): filter out SSTs for time travel metadata Dec 6, 2024
@Li0k
Copy link
Contributor

Li0k commented Dec 17, 2024

rewriting is LGTM.

My question is: The PR retains three types

  • TableType::Table
  • TableType::MaterializedView
  • TableType::Index

This is not consistent with the previous implementation (which only kept MaterializedView), is this as expected? Can you add some pr description.

@zwang28
Copy link
Contributor Author

zwang28 commented Dec 18, 2024

This is not consistent with the previous implementation (which only kept MaterializedView), is this as expected? Can you add some pr description.

Only user-queryable state tables are included in the time travel metadata, both for previous implementation and current one.

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@Li0k Li0k added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify MV tables in HummockVersion
2 participants