Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): support replace source #19650

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Finish the meta part of #19063:

    1. extend match &stream_job from Table to Source
    1. handle split assignment for replace (need to align to prev actors, because of source backfill is aligned)
  • Also changed the grpc interface from table to job.

e2e tests can be seem in #19649

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan force-pushed the 09-17-feat_support_alter_shared_source branch 2 times, most recently from 016e23b to a373c13 Compare December 3, 2024 08:28
@xxchan xxchan force-pushed the 12-03-feat_meta_support_replace_source branch from e7756d6 to c3219ea Compare December 3, 2024 08:29
@xxchan xxchan changed the base branch from 09-17-feat_support_alter_shared_source to graphite-base/19650 December 3, 2024 09:09
@xxchan xxchan force-pushed the graphite-base/19650 branch from a373c13 to c2ee827 Compare December 3, 2024 09:53
@xxchan xxchan force-pushed the 12-03-feat_meta_support_replace_source branch from c3219ea to 89ea6eb Compare December 3, 2024 09:54
@xxchan xxchan changed the base branch from graphite-base/19650 to main December 3, 2024 09:54
@xxchan xxchan force-pushed the 12-03-feat_meta_support_replace_source branch 2 times, most recently from d56b1da to 0ab300f Compare December 4, 2024 01:17
@xxchan xxchan marked this pull request as ready for review December 4, 2024 01:18
@xxchan xxchan force-pushed the 12-03-feat_meta_support_replace_source branch 2 times, most recently from 55aa35f to 8a37656 Compare December 5, 2024 08:35
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

src/meta/src/stream/source_manager.rs Outdated Show resolved Hide resolved
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

proto/ddl_service.proto Outdated Show resolved Hide resolved
src/meta/src/model/stream.rs Show resolved Hide resolved
src/meta/src/stream/source_manager.rs Show resolved Hide resolved
@xxchan xxchan requested a review from BugenZhao December 9, 2024 09:48
@xxchan
Copy link
Member Author

xxchan commented Dec 10, 2024

@BugenZhao look look

@xxchan xxchan enabled auto-merge December 10, 2024 05:55
@xxchan xxchan added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@xxchan xxchan added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@xxchan xxchan force-pushed the 12-03-feat_meta_support_replace_source branch from 835348d to ffb51b8 Compare December 10, 2024 08:24
@xxchan xxchan enabled auto-merge December 10, 2024 08:25
@xxchan xxchan added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit d2bb1db Dec 10, 2024
33 of 35 checks passed
@xxchan xxchan deleted the 12-03-feat_meta_support_replace_source branch December 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants