Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hummock): fix hummock_trace panic with log store #19606

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Nov 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #18502

Our new_local needs to get local_id when hummock_trace is turned on, and this this task will only be saved at the time of build executor, so get local_id at do_exec time will panic

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs requested a review from wenym1 November 28, 2024 10:53
@github-actions github-actions bot added the type/fix Bug fix label Nov 28, 2024
@wenym1
Copy link
Contributor

wenym1 commented Nov 29, 2024

Just pushed a commit to revert the previous change. To fix this issue, a better way is wrap task local scope to the out-most actor future before we spawn it. The actor future includes both the build and execute stage, so the issue should be fixed.

@wenym1 wenym1 requested a review from hzxa21 November 29, 2024 07:00
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I don't get why this will cause #18502. Does it mean that risedev d full will use hummock tracing?

@xxhZs
Copy link
Contributor Author

xxhZs commented Dec 2, 2024

LGTM.

But I don't get why this will cause #18502. Does it mean that risedev d full will use hummock tracing?

Having communicated privately with congyi, it is he who has the . /risedev config opened hummock tracing

@xxhZs xxhZs added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@xxhZs xxhZs added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 303ab11 Dec 2, 2024
30 of 31 checks passed
@xxhZs xxhZs deleted the xxh/fix-panic-hummock-tracing branch December 2, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File sink can not work after enable sink_decouple
3 participants