fix(meta): do not release connection to in-memory SQLite for meta store #19605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
github-actions
bot
added
type/fix
yezizp2012
approved these changes
Nov 28, 2024
fuyufjh
reviewed
Nov 28, 2024
| let conn = sea_orm::Database::connect(IN_MEMORY_STORE).await?; | ||
| const IN_MEMORY_STORE: &str = "sqlite::memory:"; | ||
|
|
||
| let mut options = sea_orm::ConnectOptions::new(IN_MEMORY_STORE); |
There was a problem hiding this comment.
A more elegant solution might be "Temporary Databases"? No additional options are needed.
https://www.sqlite.org/inmemorydb.html (Scroll down to the "Temporary Databases" section)
There was a problem hiding this comment.
Temporary databases are automatically deleted when the connection that created them closes.
Seems that this still holds.
No additional options are needed.
Actually those options are for the connection pool by sqlx, not SQLite.
BugenZhao
force-pushed
the
bz/extract-sql-meta-store-connect
branch
from
6d649e0 to
fb9573e
Compare
BugenZhao
force-pushed
the
bz/in-mem-meta-store-do-not-release
branch
from
613c35c to
8d1fcec
Compare
4 tasks
BugenZhao
force-pushed
the
bz/extract-sql-meta-store-connect
branch
from
fb9573e to
926ae81
Compare
BugenZhao
force-pushed
the
bz/in-mem-meta-store-do-not-release
branch
from
8d1fcec to
d0acbe1
Compare
BugenZhao
force-pushed
the
bz/in-mem-meta-store-do-not-release
branch
from
d0acbe1 to
0cb233b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #19522.
The connection options to meta store exposed in #19040 do not apply to in-memory SQLite (typically used by
playground). Therefore, default values fromsea-ormorsqlxwere used, wheremax_lifetimeis set to 30 minutes. This means that #19522 will always occur after launchingplaygroundand waiting for 30 minutes, no matter whether there is any activity or not.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.