Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): extract code for connecting sql meta store #19603

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Extract function for connecting to a SQL meta store from a backend configuration.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Nov 28, 2024

@BugenZhao BugenZhao force-pushed the bz/extract-sql-meta-store-connect branch from 6d649e0 to fb9573e Compare November 29, 2024 03:49
@BugenZhao BugenZhao changed the base branch from main to bz/bypass-cluster-limits-debug-build November 29, 2024 03:49
Base automatically changed from bz/bypass-cluster-limits-debug-build to main November 29, 2024 05:39
@BugenZhao BugenZhao force-pushed the bz/extract-sql-meta-store-connect branch from fb9573e to 926ae81 Compare December 9, 2024 05:18
@BugenZhao BugenZhao enabled auto-merge December 9, 2024 05:19
@BugenZhao BugenZhao added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 9b26a96 Dec 9, 2024
32 of 33 checks passed
@BugenZhao BugenZhao deleted the bz/extract-sql-meta-store-connect branch December 9, 2024 09:33
wenym1 pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants