Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tpch/nexmark tests for shared kafka source #19589

Merged
merged 1 commit into from
Nov 28, 2024
Merged

test: add tpch/nexmark tests for shared kafka source #19589

merged 1 commit into from
Nov 28, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 27, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Note: for planner tests, I just make sure they can be generated. Haven't checked all the plans yet.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan marked this pull request as ready for review November 27, 2024 06:05
@xxchan Graphite App
Copy link
Member Author

xxchan commented Nov 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@xxchan xxchan mentioned this pull request Nov 27, 2024
Merged
9 tasks
@github-actions github-actions bot added the component/test Test related issue. label Nov 27, 2024
@xxchan xxchan force-pushed the xxchan/sporting-gopher branch from e61510f to 39e77fb Compare November 27, 2024 06:14
@xxchan xxchan force-pushed the 11-27-test_add_tpch_nexmark_tests_for_shared_kafka_source branch from 17ccb4f to 532e840 Compare November 27, 2024 06:14
@BugenZhao
Copy link
Member

Previously we don't have nexmark source test on CI, even for non-shared source?

@xxchan
Copy link
Member Author

xxchan commented Nov 27, 2024 •
edited
Loading

We have connector='nexmark' tests (in nexmark-endless), no Kafka tests.

@xxchan
Copy link
Member Author

xxchan commented Nov 27, 2024

I had thought CI covered many cases, so didn't add many tests for shared source. But it turns out there are very few tests for Kafka. Most streaming tests are based on tables.

st1page
st1page approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I have a feeling that no one has thought of generating data in e2e test with risingwave sink before

@xxchan
Copy link
Member Author

xxchan commented Nov 27, 2024

Interesting, I have a feeling that no one has thought of generating data in e2e test with risingwave sink before

I learned from @kwannoel

@xxchan xxchan force-pushed the xxchan/sporting-gopher branch from ee18a7e to fd14a95 Compare November 27, 2024 12:01
@xxchan xxchan force-pushed the 11-27-test_add_tpch_nexmark_tests_for_shared_kafka_source branch from 532e840 to 1f1ab07 Compare November 27, 2024 12:01
@xxchan xxchan changed the base branch from xxchan/sporting-gopher to graphite-base/19589 November 27, 2024 12:40
@xxchan xxchan force-pushed the 11-27-test_add_tpch_nexmark_tests_for_shared_kafka_source branch from 1f1ab07 to 1b0bbaf Compare November 27, 2024 17:32
@xxchan xxchan force-pushed the graphite-base/19589 branch from fd14a95 to ba225b2 Compare November 27, 2024 17:32
@xxchan xxchan changed the base branch from graphite-base/19589 to main November 27, 2024 17:32
@xxchan Graphite App
Copy link
Member Author

xxchan commented Nov 27, 2024 •
edited
Loading

Merge activity

  • Nov 28, 1:32 AM GMT+8: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Nov 28, 2:45 AM GMT+8: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).

@graphite-app graphite-app bot requested a review from a team November 27, 2024 18:44
@xxchan xxchan added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 42f1e1b Nov 28, 2024
29 of 30 checks passed
@xxchan xxchan deleted the 11-27-test_add_tpch_nexmark_tests_for_shared_kafka_source branch November 28, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st1page st1page st1page approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

@stdrc stdrc Awaiting requested review from stdrc

Assignees
No one assigned
Labels
component/test Test related issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @BugenZhao @st1page