-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tpch/nexmark tests for shared kafka source #19589
test: add tpch/nexmark tests for shared kafka source #19589
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e61510f
to
39e77fb
Compare
17ccb4f
to
532e840
Compare
Previously we don't have nexmark source test on CI, even for non-shared source? |
We have |
I had thought CI covered many cases, so didn't add many tests for shared source. But it turns out there are very few tests for Kafka. Most streaming tests are based on tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I have a feeling that no one has thought of generating data in e2e test with risingwave sink before
I learned from @kwannoel |
ee18a7e
to
fd14a95
Compare
532e840
to
1f1ab07
Compare
1f1ab07
to
1b0bbaf
Compare
fd14a95
to
ba225b2
Compare
Merge activity
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.