Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: shared source bug fixes (#19578, #19564) to 2.1 #19583

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

graphite-app bot commented Nov 26, 2024

Graphite Automations

"release branch request review" took an action on this PR • (11/26/24)

1 reviewer was added to this PR based on xxchan's automation.

@xxchan xxchan force-pushed the xxchan/cp-2.1-ss-bug branch from 7575ce9 to e23bf1f Compare November 26, 2024 15:31
@lmatz lmatz requested a review from cyliu0 November 27, 2024 03:25
@xxchan
Copy link
Member Author

xxchan commented Nov 27, 2024

The error in the tests seems fine

thread '<unnamed>' panicked at /risingwave/src/tests/sqlsmith/src/test_runners/fuzzing.rs:37:57:
called `Result::unwrap()` on an `Err` value: Encountered unexpected error: db error: ERROR: Failed to run the query

Caused by:
  Expr error: error while evaluating expression `sqrt_f64('-7768382570.666667')`: Invalid parameter sqrt input: input cannot be negative value


@xxchan xxchan force-pushed the xxchan/cp-2.1-ss-bug branch from 2cfb26b to 5897aa0 Compare November 28, 2024 00:42
@xxchan xxchan enabled auto-merge November 28, 2024 00:44
@xxchan
Copy link
Member Author

xxchan commented Nov 28, 2024

reapplied changes. need another approve

@xxchan xxchan requested a review from BugenZhao November 28, 2024 00:45
@xxchan xxchan added this pull request to the merge queue Nov 28, 2024
Merged via the queue into release-2.1 with commit 3804ce2 Nov 28, 2024
23 of 27 checks passed
@xxchan xxchan deleted the xxchan/cp-2.1-ss-bug branch November 28, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants