Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor bug of to_binary_with_type of List #19571

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: minor bug of to_binary_with_type of List #19571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/src/types/to_binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ impl ToBinary for ListRef<'_> {
buf.put_i32(1); // Has nulls?
buf.put_i32(element_ty.to_oid()); // Element type
buf.put_i32(self.len() as i32); // Length of 1st dimension
buf.put_i32(0); // Offset of 1st dimension
buf.put_i32(1); // Offset of 1st dimension, starting from 1
for element in self.iter() {
match element {
None => {
Expand Down
Loading