feat(risedev): support configuring meta store by url from env var #19560
+153
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
requested review from
lmatz,
yezizp2012 and
xxchan
and removed request for
lmatz
stdrc
reviewed
Nov 25, 2024
xxchan
approved these changes
Nov 25, 2024
| @@ -245,6 +260,18 @@ impl Task for MetaNodeService { | |||
| cmd.arg("--config-path") | |||
| .arg(Path::new(&prefix_config).join("risingwave.toml")); | |||
|
|
|||
| if let MetaBackend::Env = self.config.meta_backend { | |||
| if is_env_set("RISEDEV_CLEAN_START") { | |||
There was a problem hiding this comment.
It might be a little confusing that RISEDEV_CLEAN_START only works with meta-backend: env
There was a problem hiding this comment.
It's not meant to be set by user directly but when running risedev ci-start.
The basic idea is that, I don't want to hack the procedure of risedev clean-data to involve such operation, so it's postponed to the next startup. It only applies to ci-start because
- the main motivation is CI as described in make ci e2e scripts meta backend agnostic #19527
- for
ci-startwe are sure that we want a fresh cluster
|
yaml not updated? 👀 |
Won't be in this PR. 🥰 |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
BugenZhao
force-pushed
the
bz/junior-jackal
branch
from
52500b9 to
e802bee
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/junior-jackal
branch
from
e638784 to
be023ee
Compare
4 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See ideas in #19527.
When specifying
meta-backend: envfor the meta-node service inrisedev dev, RiseDev will now pass it verbatim as--sql-endpointto the meta node.Additionally, if the cluster is started with
ci-start, RiseDev will help to recreate the database that will be used.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.