Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): better cast error message for UPDATE setting to subquery #19555

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

...by specifying field name for the struct type. See changes on e2e tests.

Based on #19402 and #19449.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge November 26, 2024 04:08
@BugenZhao BugenZhao added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit b34f4fd Nov 26, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/better-update-subquery-cast-error-message branch November 26, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants