Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick fix: when target is table, the sink downstream pk is not set (#19515) to branch release-2.0 #19553

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Nov 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #19544

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@st1page st1page requested a review from shanicky November 25, 2024 04:50
@graphite-app graphite-app bot requested a review from lmatz November 25, 2024 05:17
Copy link

graphite-app bot commented Nov 25, 2024

Graphite Automations

"release branch request review" took an action on this PR • (11/25/24)

1 reviewer was added to this PR based on xxchan's automation.

@st1page st1page enabled auto-merge November 25, 2024 06:54
@st1page st1page added this pull request to the merge queue Nov 25, 2024
Merged via the queue into release-2.0 with commit 7a15a71 Nov 25, 2024
26 of 27 checks passed
@st1page st1page deleted the sts/cp20 branch November 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants