Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): (WIP/Preview) optional name for struct data type #19538

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Motivation

Given the following column with multiple levels of nested struct:

a struct<     -- let's call this struct A
  a struct<   -- struct AA
    a struct< -- struct AAA
      a int2,
      b int4
    >,
    b struct< -- struct AAB
      a int8,
      b decimal
    >
  >,
  b struct<   -- struct AB
    a struct< -- struct ABA
      a float4,
      b float8
    >,
    b struct< -- struct ABB
      a varchar,
      b bytea
    >
  >
>

The current ColumnDesc contains duplicate information:

ColumnDesc { -- column a of type A
  column_type: Struct:::field_types [
    Struct::field_types [
      Struct::field_types [
        Int16,
        Int32,
      ],
      Struct::field_types [
        Int64,
        Decimal,
      ],
    ],
    Struct::field_types [
      Struct::field_types [
        Float32,
        Float64,
      ],
      Struct::field_types [
        Varchar,
        Bytea,
      ],
    ],
  ],
  field_descs: [
    ColumnDesc { -- field (a).a of type AA
      column_type: Struct::field_types [
        Struct::field_types [
          Int16,
          Int32,
        ],
        Struct::field_types [
          Int64,
          Decimal,
        ],
      ],
      field_descs: [
        ColumnDesc { -- field (a).a.a of type AAA
          column_type: Struct::field_types [
            Int16,
            Int32,
          ],
          field_descs: [
            ColumnDesc { -- field (a).a.a.a
              column_type: Int16,
            },
            ColumnDesc { -- field (a).a.a.b
              column_type: Int32,
            },
          ],
        },
        ColumnDesc { -- field (a).a.b of type AAB
          column_type: Struct::field_types [
            Int64,
            Decimal,
          ],
          field_descs: [
            ColumnDesc { -- field (a).a.b.a
              column_type: Int64,
            },
            ColumnDesc { -- field (a).a.b.b
              column_type: Decimal,
            },
          ],
        },
      ],
    },
    ColumnDesc { -- field (a).b of type AB
      column_type: Struct::field_types [
        Struct::field_types [
          Float32,
          Float64,
        ],
        Struct::field_types [
          Varchar,
          Bytea,
        ],
      ],
      field_descs: [
        ColumnDesc { -- field (a).b.a of type ABA
          column_type: Struct::field_types [
            Float32,
            Float64,
          ],
          field_descs: [
            ColumnDesc { -- field (a).a.a.a
              column_type: Float32,
            },
            ColumnDesc { -- field (a).a.a.b
              column_type: Float64,
            },
          ],
        },
        ColumnDesc { -- field (a).b.b of type ABB
          column_type: Struct::field_types [
            Varchar,
            Bytea,
          ],
          field_descs: [
            ColumnDesc { -- field (a).a.b.a
              column_type: Varchar,
            },
            ColumnDesc { -- field (a).a.b.b
              column_type: Bytea,
            },
          ],
        },
      ],
    },
  ],
}

The ultimate goal is to deprecated field_descs and keep column_type. So column_type need the ability to hold the optional name of struct type.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu changed the title refactor(common): (WIP/Review) optional name for struct data type refactor(common): (WIP/Preview) optional name for struct data type Nov 22, 2024
@xiangjinwu xiangjinwu force-pushed the refactor-struct-name-WIP branch from 78aa067 to bf1a4e3 Compare November 27, 2024 06:30
@xiangjinwu xiangjinwu force-pushed the refactor-struct-name-WIP branch from bf1a4e3 to 10da69c Compare December 11, 2024 08:50
@xiangjinwu xiangjinwu force-pushed the refactor-struct-name-WIP branch from 10da69c to edfcb38 Compare December 13, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant