Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builtin function timezone #19524

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

chagelo
Copy link
Contributor

@chagelo chagelo commented Nov 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #17363

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chagelo chagelo force-pushed the feat-add-func-timezone branch 2 times, most recently from 9eb085d to effebef Compare November 21, 2024 10:55
@chagelo chagelo marked this pull request as ready for review November 21, 2024 10:58
@chagelo chagelo force-pushed the feat-add-func-timezone branch 2 times, most recently from ac35e6b to f981424 Compare November 22, 2024 08:27
@graphite-app graphite-app bot requested a review from a team November 22, 2024 08:43
@xiangjinwu
Copy link
Contributor

Thanks for your contribution. For testing, add new cases to e2e_test/ in the sqllogictest format rather than to src/tests/regress/.

@chagelo
Copy link
Contributor Author

chagelo commented Nov 26, 2024

@lmatz, PTAL

@chagelo chagelo force-pushed the feat-add-func-timezone branch from d189c94 to 3ead68f Compare November 26, 2024 09:37
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 27, 2024
Merged via the queue into risingwavelabs:main with commit 0669783 Nov 27, 2024
28 of 29 checks passed
@chagelo chagelo deleted the feat-add-func-timezone branch November 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support function timezone(zone, timestamp)
2 participants