fix: when target is table, the sink downstream pk is not set #19515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Nov 21, 2024
|
|
||
| statement ok | ||
| SET STREAMING_PARALLELISM TO 3; | ||
|
|
||
| statement ok | ||
| create sink s_simple_1 into m_simple as select v1, v2 from t_simple; | ||
| create sink s_simple_1 into m_simple as select v1, v2 from t_simple with (type = 'append-only'); |
There was a problem hiding this comment.
Change the query because if there is primary key, the original sink plan will be
dev=> explain create sink s_simple_1 into m_simple as select v1, v2 from t_simple;
;
QUERY PLAN
----------------------------------------------------------------------------------------------------------
StreamProject { exprs: [t_simple.v1, t_simple.v2] }
└─StreamSink { type: upsert, columns: [v1, v2, t_simple._row_id(hidden)], downstream_pk: [t_simple.v1] }
└─StreamExchange { dist: HashShard(t_simple.v1) }
└─StreamTableScan { table: t_simple, columns: [v1, v2, _row_id] }
(4 rows)
st1page
commented
Nov 22, 2024
Comment on lines
+277
to
+286
| let target_table_mapping = target_table_mapping.unwrap(); | ||
|
|
||
| t.pk() | ||
| .iter() | ||
| .map(|c| { | ||
| target_table_mapping[c.column_index].ok_or( | ||
| ErrorCode::SinkError(Box::new(Error::new(ErrorKind::InvalidInput, | ||
| "When using non append only sink into table, the primary key of the table must be included in the sink result.".to_string() | ||
| ))).into())}) | ||
| .try_collect::<_, _, RwError>()? |
There was a problem hiding this comment.
main changes it to get the down stream pk here, and to get it, the target_table_mapping is needed
shanicky
approved these changes
Nov 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
st1page
added a commit
that referenced
this pull request
Nov 22, 2024
st1page
added a commit
that referenced
this pull request
Nov 22, 2024
st1page
added a commit
that referenced
this pull request
Nov 25, 2024
st1page
added a commit
that referenced
this pull request
Nov 25, 2024
cyliu0
pushed a commit
to cyliu0/risingwave
that referenced
this pull request
Nov 30, 2024
…set (risingwavelabs#19515) to branch release-2.1 (risingwavelabs#19554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.