fix(compactor): introduce dedicated config for compactor meta cache #19484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/compactor_memory_config
Li0k
changed the title
hzxa21
reviewed
Nov 28, 2024
| let memory_collector = Arc::new(HummockMemoryCollector::new( | ||
| sstable_store.clone(), | ||
| memory_limiter.clone(), | ||
| storage_memory_config, | ||
| )); | ||
|
|
||
| let heap_profiler = HeapProfiler::new( | ||
| system_memory_available_bytes(), | ||
| compactor_opts.compactor_total_memory_bytes, |
There was a problem hiding this comment.
Is this correct? The documentation of HeapProfiler says:
total_memorymust be the total available memory for the process.
It will be compared with the process resident memory.
There was a problem hiding this comment.
Correct me if I'm wrong.
I refer to cn's approach, where compactor_opts.compactor_total_memory_bytes represents the memory limit for the current process, whether it is a dedicated or standalone deployment.
I understand that after #19477, standalone will also set total_memory_bytes for cn, so the current pr is similar to CN.
…nto li0k/compactor_memory_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
introduce dedicated config for compactor meta cache, avoiding misuse of CN's meta cache configuration in environments that lack config map isolation.
And PR removed the misuse of
extract_storage_memory_configand corrects a problem with HeapProfiler's wrongtotal_memoryparameters.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.