Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow modification of the query mode (#19424) #19455

Merged
merged 1 commit into from
Nov 20, 2024
+1 −4
Merged

refactor: allow modification of the query mode (#19424) #19455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions e2e_test/ddl/alter_session_params.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
statement ok
set RW_STREAMING_ENABLE_DELTA_JOIN to true;

statement error session param query_mode cannot be altered system wide
alter system set query_mode to auto;

connection other1
query T
show RW_STREAMING_ENABLE_DELTA_JOIN;
Expand Down
2 changes: 1 addition & 1 deletion src/common/src/session_config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ pub struct SessionConfig {
/// The default value is auto which means let the system decide to run batch queries in local
/// or distributed mode automatically.
#[serde_as(as = "DisplayFromStr")]
#[parameter(default = QueryMode::default(), flags = "NO_ALTER_SYS")]
#[parameter(default = QueryMode::default())]
query_mode: QueryMode,

/// Sets the number of digits displayed for floating-point values.
Expand Down
Loading