-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pgwire): support 1-dimension array in extended mode #19432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core functionality LGTM.
Adding some notes for other reviewers who are not as familiar with PG coding conventions (like myself), so it's easier for them to review it.
The core functionality is specifically in these lines:
https://github.com/postgres/postgres/blob/c1c09007e219ae68d1f8428a54baf68ccc1f8683/src/backend/utils/adt/arrayfuncs.c#L1606-L1644.
Some things to take note of:
pq_sendint32(&buf, VARSIZE(outputbytes) - VARHDRSZ);
Here this just gets the length of outputbytes. VARSIZE
gets the size of varlena
. VARHDRSZ
is the header len of varlena
. Subtracting them gives us the data len.
AARR_DIMS
gives us the dimension of each array (i.e. the len).
AARR_LBOUND
gives us the starting offset for each array.
refine text Co-authored-by: Noel Kwan <[email protected]>
buf.put_i32(1); // Has nulls? | ||
buf.put_i32(element_ty.to_oid()); // Element type | ||
buf.put_i32(self.len() as i32); // Length of 1st dimension | ||
buf.put_i32(0); // Offset of 1st dimension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQL array starts at 1 rather than 0.
test=# select array_send(array[2, 3, null]);
array_send
------------------------------------------------------------------------------------
\x000000010000000100000017000000030000000100000004000000020000000400000003ffffffff
(1 row)
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Related #7949
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.