Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): unpin snapshot until the end of distributed batch query #19429

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Nov 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled. Fix the potential race between FE and CN on pinned epoch. This fix is valid for version <= 2.0 because in 2.1 we already deprecate safe epoch completely.

See #17965 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Nov 18, 2024
@github-actions github-actions bot added the type/fix Bug fix label Nov 18, 2024
@graphite-app graphite-app bot requested a review from lmatz November 18, 2024 08:28
Copy link

graphite-app bot commented Nov 18, 2024

Graphite Automations

"release branch request review" took an action on this PR • (11/18/24)

1 reviewer was added to this PR based on xxchan's automation.

@lmatz lmatz added this pull request to the merge queue Nov 19, 2024
Merged via the queue into release-2.0 with commit f7c518d Nov 19, 2024
25 of 26 checks passed
@lmatz lmatz deleted the patrick/hotfix-expired-watermark branch November 19, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants