fix(test): incorrect flaky madsim initial sink parallelism #19419
+15
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previous in sink decouple madsim test, we assume that the sink writer of all sink parallelisms should be created after the create sink SQL returns. However, when sink decouple is enabled, the sink writer will be created in the log reader side, which is decoupled from the upstream. Therefore, it may happen that when the create sink SQL returns, not all sink writer have been created, and some related tests become flaky. In this PR, we change to explicitly wait for all sink writer parallelisms to be created before proceeding to next step, and the flaky tests will be fixed.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.