Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): incorrect flaky madsim initial sink parallelism #19419

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previous in sink decouple madsim test, we assume that the sink writer of all sink parallelisms should be created after the create sink SQL returns. However, when sink decouple is enabled, the sink writer will be created in the log reader side, which is decoupled from the upstream. Therefore, it may happen that when the create sink SQL returns, not all sink writer have been created, and some related tests become flaky. In this PR, we change to explicitly wait for all sink writer parallelisms to be created before proceeding to next step, and the flaky tests will be fixed.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 changed the title fix: (reproduce) incorrect madsim initial sink parallelism fix(test): incorrect flaky madsim initial sink parallelism Nov 18, 2024
@graphite-app graphite-app bot requested a review from a team November 18, 2024 08:31
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wenym1 wenym1 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 0b223b4 Nov 18, 2024
34 of 35 checks passed
@wenym1 wenym1 deleted the yiming/reproduce-madsim-sink-parallelism-panic branch November 18, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment