Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(udf): remove function_type field previously used by Deno UDF #19404

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Nov 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR removes the unused function_type field from all structures related to user-defined functions (#16263). runtime is kept because it seems to be more general, so may be useful in the future.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Nov 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@stdrc stdrc changed the title remove function_type field from UDF metadata refactor(udf): remove function_type field previously used by Deno UDF from UDF metadata Nov 15, 2024
@stdrc stdrc marked this pull request as ready for review November 15, 2024 09:04
@stdrc stdrc changed the title refactor(udf): remove function_type field previously used by Deno UDF from UDF metadata refactor(udf): remove function_type field previously used by Deno UDF Nov 15, 2024
@stdrc stdrc enabled auto-merge November 15, 2024 09:17
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/remove-frontend-deno-udf branch from db7200c to 44dd9e6 Compare November 17, 2024 16:21
@stdrc stdrc added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit 94154c0 Nov 17, 2024
34 of 35 checks passed
@stdrc stdrc deleted the rc/remove-frontend-deno-udf branch November 17, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants